mapleFU commented on code in PR #40223:
URL: https://github.com/apache/arrow/pull/40223#discussion_r1501757033
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -527,6 +527,36 @@ inline std::vector<TypeHolder>
GetTypesWithSmallestLiteralRepresentation(
return types;
}
+namespace {
+
+bool IsBaiscArithmeticOperations(std::string function_name) {
Review Comment:
`const std::string&` as argument?
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -527,6 +527,36 @@ inline std::vector<TypeHolder>
GetTypesWithSmallestLiteralRepresentation(
return types;
}
+namespace {
+
+bool IsBaiscArithmeticOperations(std::string function_name) {
+ static std::unordered_set<std::string> baisc_arithmetic_operations{
Review Comment:
const?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
