houqp commented on a change in pull request #9256:
URL: https://github.com/apache/arrow/pull/9256#discussion_r568339523
##########
File path: rust/arrow/src/array/cast.rs
##########
@@ -40,12 +40,20 @@ where
.expect("Unable to downcast to dictionary array")
}
-pub fn as_list_array<S: OffsetSizeTrait>(arr: &ArrayRef) ->
&GenericListArray<S> {
+pub fn as_generic_list_array<S: OffsetSizeTrait>(arr: &ArrayRef) ->
&GenericListArray<S> {
arr.as_any()
.downcast_ref::<GenericListArray<S>>()
.expect("Unable to downcast to list array")
}
+pub fn as_list_array(arr: &ArrayRef) -> &ListArray {
Review comment:
@jorgecarleitao the main reason for adding that is to keep these two
cast function names consistent with others. i.e. for a particular `FooBarArray`
type, there exists a `as_foo_bar_array` cast function. However, if you have
strong opinion on this, I am happy to remove it.
I have added the inline annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
