zanmato1984 commented on issue #40069: URL: https://github.com/apache/arrow/issues/40069#issuecomment-1963580204
> Thank you. It looks like calling `ArraySpan::FillFromScalar` from several threads is legitimate when the same scalar is used as input for different computations. Given that this is probably always writing the same value, it would probably be enough to use relaxed atomic stores. > > @bkietz @pitrou Just a thought, seems like the information to fill into the scalar's scratch space is totally self-contained, should we do the filling by a (virtual) member function of the scalar class, e.g. `virtual BufferSpan Scalar::FillScrach(...)`? And we can probably use an acquire-release atomic flag to mark if the scratch has already been filled. This might be more semantically clear imho. (But this may bring ABI issues, which I'm not sure how is dealt with in arrow.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
