CurtHagenlocher commented on code in PR #1566:
URL: https://github.com/apache/arrow-adbc/pull/1566#discussion_r1502983146
##########
csharp/src/Client/SchemaConverter.cs:
##########
@@ -70,8 +70,17 @@ public static DataTable ConvertArrowSchema(Schema schema,
AdbcStatement adbcStat
f.HasMetadata
)
{
- row[SchemaTableColumn.NumericPrecision] =
Convert.ToInt32(f.Metadata["precision"]);
- row[SchemaTableColumn.NumericScale] =
Convert.ToInt32(f.Metadata["scale"]);
+ if (f.Metadata.TryGetValue("precision", out string
precisionKey))
Review Comment:
consider for slightly greater robustness
` if (f.Metadata.TryGetValue("precision", out string precisionKey) &&
int32.TryParse(precisionKey, out int precision))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
