sunchao commented on code in PR #112:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/112#discussion_r1502998914
##########
.github/actions/setup-macos-builder/action.yaml:
##########
@@ -49,12 +49,13 @@ runs:
unzip $PROTO_ZIP
echo "$HOME/d/protoc/bin" >> $GITHUB_PATH
export PATH=$PATH:$HOME/d/protoc/bin
- # install openssl and setup DYLD_LIBRARY_PATH to work with
libcrypto.dylib loading issues with x86_64 mac runners
- # see PR https://github.com/apache/arrow-datafusion-comet/pull/55 for
more details
+ # install openssl and setup DYLD_LIBRARY_PATH
brew install openssl
- OPENSSL_LIB_PATH=$(dirname `brew list openssl | grep
'lib/libcrypto.dylib'`)
+ OPENSSL_LIB_PATH=`brew --prefix openssl`/lib
echo "openssl lib path is: ${OPENSSL_LIB_PATH}"
- export DYLD_LIBRARY_PATH=$OPENSSL_LIB_PATH:$DYLD_LIBRARY_PATH
+ echo "DYLD_LIBRARY_PATH=$OPENSSL_LIB_PATH:$DYLD_LIBRARY_PATH" >>
$GITHUB_ENV
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]