felipecrv commented on code in PR #40226:
URL: https://github.com/apache/arrow/pull/40226#discussion_r1503181319
##########
ci/docker/linux-apt-docs.dockerfile:
##########
@@ -79,8 +79,14 @@ RUN apt-get purge -y npm && \
COPY docs/requirements.txt /arrow/docs/
RUN pip install -r arrow/docs/requirements.txt meson
+# TODO: Why is this failing?
+#
+# > [10/16] RUN gem install --no-document bundler && bundle install
--gemfile /arrow/c_glib/Gemfile:
+# 24.94 ERROR: Error installing bundler:
+# 24.94 The last version of bundler (>= 0) to support your Ruby & RubyGems
was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
+# 24.94 bundler requires Ruby version >= 3.0.0. The current ruby version is
2.7.0.0.
COPY c_glib/Gemfile /arrow/c_glib/
-RUN gem install --no-document bundler && \
+RUN gem install --no-document bundler -v 2.4.22 && \
Review Comment:
Locally or in CI?
##########
cpp/src/arrow/compute/kernels/chunked_internal.h:
##########
@@ -61,16 +61,16 @@ struct ResolvedChunk<Array> {
bool IsNull() const { return array->IsNull(index); }
};
-struct ChunkedArrayResolver : protected ::arrow::internal::ChunkResolver {
+struct ChunkedArrayResolver : protected ::arrow::ChunkResolver {
ChunkedArrayResolver(const ChunkedArrayResolver& other)
- : ::arrow::internal::ChunkResolver(other.chunks_),
chunks_(other.chunks_) {}
+ : ::arrow::ChunkResolver(other.chunks_), chunks_(other.chunks_) {}
explicit ChunkedArrayResolver(const std::vector<const Array*>& chunks)
- : ::arrow::internal::ChunkResolver(chunks), chunks_(chunks) {}
+ : ::arrow::ChunkResolver(chunks), chunks_(chunks) {}
template <typename ArrayType>
ResolvedChunk<ArrayType> Resolve(int64_t index) const {
- const auto loc = ::arrow::internal::ChunkResolver::Resolve(index);
+ const auto loc = ::arrow::ChunkResolver::Resolve(index);
Review Comment:
You could actually remove the `::arrow` now because the compile won't be
confused by `::arrow::internal` and `::arrow::compute::internal` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
