kou commented on PR #40234:
URL: https://github.com/apache/arrow/pull/40234#issuecomment-1965215981
It seems that we need only one batch size (we don't need batch sizes for
left and right). How about this instead?
```diff
diff --git a/cpp/src/arrow/acero/asof_join_benchmark.cc
b/cpp/src/arrow/acero/asof_join_benchmark.cc
index 600c230a3f..02116b09fc 100644
--- a/cpp/src/arrow/acero/asof_join_benchmark.cc
+++ b/cpp/src/arrow/acero/asof_join_benchmark.cc
@@ -131,9 +131,8 @@ static void AsOfJoinOverhead(benchmark::State& state) {
// this generates the set of right hand tables to test on.
void SetArgs(benchmark::internal::Benchmark* bench) {
bench
- ->ArgNames({"left_freq", "left_cols", "left_ids", "left_batch_size",
- "num_right_tables", "right_freq", "right_cols",
"right_ids",
- "right_batch_size"})
+ ->ArgNames({"left_freq", "left_cols", "left_ids", "batch_size",
"num_right_tables",
+ "right_freq", "right_cols", "right_ids"})
->UseRealTime();
int default_freq = 400;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
