alamb commented on issue #9291: URL: https://github.com/apache/arrow-datafusion/issues/9291#issuecomment-1965234842
> Not sure what to do about references to to_timestamp function in test code such as > > * core/tests/parquet/row_group_pruning.rs > * core/tests/parquet/page_pruning.rs I think the core tests will be fine as they should already have access to the (core) `datafusion` crate and thus to the functions in question > * optimizer/simplify_expressions/simplify_exprs.rs > > This seems mostly to be in tests however I'm unsure of the wisdom of adding a dependency to datafusion-functions in these modules (core/optimizer/etc) I agree we should avoid this dependency if possible One potential way to fix this dependency is to move most of the actual tests out of `optimizer/simplify_expressions/simplify_exprs.rs` and into `core/tests/` somewhere -- perhaps into https://github.com/apache/arrow-datafusion/blob/a9f0c7afe2ea3bb14bfcceedfcd33cfe4b954035/datafusion/core/tests/simplification.rs#L1-L0 Many of those simplify tests seem to be tests that certain functions get simplified rather than a unit test of the optimizer. Thus they make more sense to be in the core crate from my perspective. What do you think @Omega359 ? I am sorry for the late response > > The issue really isn't limited to to_timestamp functions - any tests in those crates that use functions that we move to the new crate will have the same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
