kou commented on code in PR #40244:
URL: https://github.com/apache/arrow/pull/40244#discussion_r1503314552
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -199,7 +199,7 @@ def credentials(self, url, username_from_url,
allowed_types):
raise CrossbowError(msg)
if (allowed_types &
- pygit2.credentials.GIT_CREDENTIAL_USERPASS_PLAINTEXT):
+ pygit2.credentials.CredentialType.USERPASS_PLAINTEXT):
Review Comment:
It seems that this requires pygit2 1.14.0 or later. Could you also update
required pygit2?
```diff
diff --git a/dev/archery/setup.py b/dev/archery/setup.py
index 2ecc72e04e..f502876856 100755
--- a/dev/archery/setup.py
+++ b/dev/archery/setup.py
@@ -29,7 +29,7 @@ jinja_req = 'jinja2>=2.11'
extras = {
'benchmark': ['pandas'],
- 'crossbow': ['github3.py', jinja_req, 'pygit2>=1.6.0', 'requests',
+ 'crossbow': ['github3.py', jinja_req, 'pygit2>=1.14.0', 'requests',
'ruamel.yaml', 'setuptools_scm<8.0.0'],
'crossbow-upload': ['github3.py', jinja_req, 'ruamel.yaml',
'setuptools_scm'],
```
(This may break CI. So I think that separated PR is better.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
