paleolimbot opened a new pull request, #392:
URL: https://github.com/apache/arrow-nanoarrow/pull/392

   The initial version of converting ArrowArray (or stream of them) to R is 
implemented in C and is difficult to understand. Not only is this difficult 
because of the verbose C, the dispatch portion is implemented almost completely 
twice (once for a single array, once for an array stream). It is at a point 
currently where it is difficult for me, let alone an external contributor, to 
add features or fix bugs. Time to refactor!
   
   This approach uses C++ classes/virtual method dispatch to handle the 
different types of vector conversions. This is similar to how the arrow R 
package does this except the Arrow R package uses the Arrow C++ converter 
infrastructure/heavy templating to do dispatch. Here we use a `switch()` and 
eat the per-batch and per-column virtual method call.
   
   Work in progress!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to