alamb commented on code in PR #9366: URL: https://github.com/apache/arrow-datafusion/pull/9366#discussion_r1504215396
########## datafusion/common/tests/macro_hygiene.rs: ########## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Could we possibly make this a module of an existing test (rather than a an entirely new test, which makes a new binary which at some point caused the CI runner to run out of disk space)? For example, somewhere in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/core_integration.rs maybe 🤔 ########## datafusion/expr/src/utils.rs: ########## @@ -129,30 +129,32 @@ fn check_grouping_sets_size_limit(size: usize) -> Result<()> { /// Merge two grouping_set /// -/// -/// Example: -/// +/// # Example +/// ```text /// (A, B), (C, D) -> (A, B, C, D) +/// ``` /// -/// Error: +/// # Error +/// - [`DataFusionError`]: The number of group_expression in grouping_set exceeds the maximum limit /// -/// [`DataFusionError`] The number of group_expression in grouping_set exceeds the maximum limit +/// [`DataFusionError`]: datafusion_common::DataFusionError fn merge_grouping_set<T: Clone>(left: &[T], right: &[T]) -> Result<Vec<T>> { check_grouping_set_size_limit(left.len() + right.len())?; Ok(left.iter().chain(right.iter()).cloned().collect()) } /// Compute the cross product of two grouping_sets /// +/// # Example Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
