kou commented on code in PR #39824:
URL: https://github.com/apache/arrow/pull/39824#discussion_r1504926113
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -249,97 +352,92 @@ set(ARROW_SRCS
util/unreachable.cc
util/uri.cc
util/utf8.cc
- util/value_parsing.cc
- vendored/base64.cpp
- vendored/datetime/tz.cpp
- vendored/double-conversion/bignum.cc
- vendored/double-conversion/bignum-dtoa.cc
- vendored/double-conversion/cached-powers.cc
- vendored/double-conversion/double-to-string.cc
- vendored/double-conversion/fast-dtoa.cc
- vendored/double-conversion/fixed-dtoa.cc
- vendored/double-conversion/string-to-double.cc
- vendored/double-conversion/strtod.cc)
-
-if(ARROW_JEMALLOC)
- list(APPEND ARROW_SRCS memory_pool_jemalloc.cc)
- set_source_files_properties(memory_pool_jemalloc.cc
- PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)
+ util/value_parsing.cc)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID
STREQUAL "Clang")
+ set_property(SOURCE util/io_util.cc
+ APPEND_STRING
+ PROPERTY COMPILE_FLAGS " -Wno-unused-macros ")
Review Comment:
I removed this and no CI weren't failed. So it seems that we don't need this
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
