alamb commented on PR #9367: URL: https://github.com/apache/arrow-datafusion/pull/9367#issuecomment-1967618058
> lgtm thanks @alamb and @jonahgao > > so package level macros prevented `cargo fmt` to run? I think the problem is https://github.com/rust-lang/rustfmt/issues/3253 -- specifically if you use a macro to define a module `cargo fmt` cant' see it. This code was previously using a macro to create code like ```rust mod core; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
