jonahgao commented on code in PR #9352:
URL: https://github.com/apache/arrow-datafusion/pull/9352#discussion_r1505279330
##########
datafusion/functions-array/src/udf.rs:
##########
@@ -83,3 +84,121 @@ impl ScalarUDFImpl for ArrayToString {
&self.aliases
}
}
+
+make_udf_function!(
+ Range,
+ range,
+ input diamilter,
Review Comment:
I think it should be
```suggestion
start stop step,
```
And it will be expanded to
```rust
pub fn range(start: Expr, stop: Expr, step: Expr) -> Expr {
Expr::ScalarFunction(
ScalarFunction::new_udf(
range_udf(),
<[_]>::into_vec(
#[rustc_box]
::alloc::boxed::Box::new([start, stop, step]),
),
),
)
}
```
`cargo expand` can help to check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
