sunchao commented on code in PR #109:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/109#discussion_r1505418769
##########
spark/src/test/scala/org/apache/comet/exec/CometColumnarShuffleSuite.scala:
##########
@@ -55,7 +50,10 @@ abstract class CometShuffleSuiteBase extends CometTestBase
with AdaptiveSparkPla
super.test(testName, testTags: _*) {
withSQLConf(
CometConf.COMET_COLUMNAR_SHUFFLE_ASYNC_ENABLED.key ->
asyncShuffleEnable.toString,
- CometConf.COMET_EXEC_SHUFFLE_SPILL_THRESHOLD.key ->
numElementsForceSpillThreshold.toString) {
+ CometConf.COMET_EXEC_SHUFFLE_SPILL_THRESHOLD.key ->
numElementsForceSpillThreshold.toString,
+ CometConf.COMET_EXEC_ENABLED.key -> "false",
Review Comment:
Yea, I forgot why we did that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
