WilliamWhispell commented on a change in pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#discussion_r568209580
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating
the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string,
...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify
second and third params are for user and serial
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating
the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string,
...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify
second and third params are for user and pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
