alamb commented on code in PR #8578:
URL: https://github.com/apache/arrow-datafusion/pull/8578#discussion_r1439725927
##########
datafusion/expr/src/udf.rs:
##########
@@ -95,6 +110,34 @@ impl ScalarUDF {
}
}
+ /// Create a new `ScalarUDF` from a `[ScalarUDFImpl]` trait object
+ ///
+ /// Note this is the same as using the `From` impl (`ScalarUDF::from`)
+ pub fn new_from_trait<F>(fun: F) -> ScalarUDF
+ where
+ F: ScalarUDFImpl + Send + Sync + 'static,
+ {
+ // TODO change the internal implementation to use the trait object
Review Comment:
https://github.com/apache/arrow-datafusion/pull/8713 is the follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
