AlenkaF commented on PR #40064: URL: https://github.com/apache/arrow/pull/40064#issuecomment-1969127085
> I am not too familiar with this part of the code base; however, I found this clean, clear, and easy to read! Thank you for looking at the PR! > I might suggest slightly fewer uses of `auto` (e.g., I don't remember if `arr.data()` is an `ArrayData` or a `std::shared_ptr<ArrayData>`); however, the usage here is definitely consistent with the rest of the Arrow code base. True, will try to do better in this regard 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
