kou commented on code in PR #39824:
URL: https://github.com/apache/arrow/pull/39824#discussion_r1506107326
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -26,6 +26,200 @@ add_dependencies(arrow-all
arrow-benchmarks
arrow-integration)
+# Libraries to link with libarrow.so. They aren't exported.
+set(ARROW_SHARED_PRIVATE_LINK_LIBS)
+
+# Libraries to link with exported libarrow.{so,a}.
+set(ARROW_SHARED_INSTALL_INTERFACE_LIBS)
+set(ARROW_STATIC_INSTALL_INTERFACE_LIBS)
+
+if(ARROW_GCS)
+ if(google_cloud_cpp_storage_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS google-cloud-cpp::storage)
+ endif()
+endif()
+
+if(ARROW_USE_OPENSSL)
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_OPENSSL_LIBS})
+endif()
+
+if(ARROW_WITH_BROTLI)
+ if(Brotli_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_BROTLI_LIBS})
+ endif()
+endif()
+
+if(ARROW_WITH_BZ2)
+ if(BZip2_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS BZip2::BZip2)
+ endif()
+endif()
+
+if(ARROW_WITH_LZ4)
+ if(lz4_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS LZ4::lz4)
+ endif()
+endif()
+
+if(ARROW_WITH_SNAPPY)
+ if(Snappy_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${Snappy_TARGET})
+ endif()
+endif()
+
+if(ARROW_WITH_ZLIB)
+ if(ZLIB_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ZLIB::ZLIB)
+ endif()
+endif()
+
+if(ARROW_WITH_ZSTD)
+ if(zstd_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_ZSTD_LIBZSTD})
+ endif()
+endif()
+
+if(ARROW_ORC)
+ if(ORC_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS orc::orc)
+ endif()
+endif()
+
+if(ARROW_USE_GLOG)
+ if(GLOG_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS glog::glog)
+ endif()
+endif()
+
+if(ARROW_S3)
+ if(AWSSDK_SOURCE STREQUAL "SYSTEM")
+ list(APPEND
+ ARROW_STATIC_INSTALL_INTERFACE_LIBS
+ aws-cpp-sdk-identity-management
+ aws-cpp-sdk-sts
+ aws-cpp-sdk-cognito-identity
+ aws-cpp-sdk-s3
+ aws-cpp-sdk-core)
+ elseif(AWSSDK_SOURCE STREQUAL "BUNDLED")
+ if(UNIX)
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl)
+ endif()
+ endif()
+endif()
+
+if(ARROW_WITH_OPENTELEMETRY)
+ if(opentelemetry_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS
${ARROW_OPENTELEMETRY_LIBS})
+ endif()
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl)
+endif()
+
+if(ARROW_WITH_UTF8PROC)
+ if(utf8proc_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS utf8proc::utf8proc)
+ endif()
+endif()
+
+if(ARROW_WITH_RE2)
+ if(re2_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS re2::re2)
+ endif()
+endif()
+
+# This should be done after if(ARROW_ORC) and if(ARROW_WITH_OPENTELEMETRY)
+# because they depend on Protobuf.
+if(ARROW_WITH_PROTOBUF)
+ if(Protobuf_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS
${ARROW_PROTOBUF_LIBPROTOBUF})
+ endif()
+endif()
+
+if(ARROW_ENABLE_THREADING)
+ list(APPEND ARROW_SHARED_PRIVATE_LINK_LIBS Threads::Threads)
+ list(APPEND ARROW_STATIC_LINK_LIBS Threads::Threads)
+endif()
+
+if(NOT MSVC_TOOLCHAIN)
+ list(APPEND ARROW_SHARED_INSTALL_INTERFACE_LIBS ${CMAKE_DL_LIBS})
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${CMAKE_DL_LIBS})
+endif()
+
+set(ARROW_TEST_LINK_TOOLCHAIN arrow::flatbuffers ${ARROW_GTEST_GMOCK}
+ ${ARROW_GTEST_GTEST_MAIN})
+set(ARROW_TEST_STATIC_LINK_LIBS arrow_testing_static arrow_static
+ ${ARROW_TEST_LINK_TOOLCHAIN})
+set(ARROW_TEST_SHARED_LINK_LIBS arrow_testing_shared arrow_shared
+ ${ARROW_TEST_LINK_TOOLCHAIN})
+if(NOT MSVC)
+ list(APPEND ARROW_TEST_SHARED_LINK_LIBS ${CMAKE_DL_LIBS})
+endif()
+
+# ----------------------------------------------------------------------
+# Handle platform-related libraries like -pthread
+
+set(ARROW_SYSTEM_LINK_LIBS)
+
+if(CMAKE_THREAD_LIBS_INIT)
+ string(APPEND ARROW_PC_LIBS_PRIVATE " ${CMAKE_THREAD_LIBS_INIT}")
+endif()
+
+if(WIN32)
+ list(APPEND ARROW_SYSTEM_LINK_LIBS "ws2_32.dll")
+endif()
+
+if(NOT WIN32 AND NOT APPLE)
+ # Pass -lrt on Linux only
+ list(APPEND ARROW_SYSTEM_LINK_LIBS rt)
+endif()
+
+list(APPEND ARROW_SHARED_INSTALL_INTERFACE_LIBS ${ARROW_SYSTEM_LINK_LIBS})
+list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_SYSTEM_LINK_LIBS})
+
+# Need -latomic on Raspbian.
+# See also: https://issues.apache.org/jira/browse/ARROW-12860
+if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux" AND ${CMAKE_SYSTEM_PROCESSOR} MATCHES
"armv7")
+ string(APPEND ARROW_PC_LIBS_PRIVATE " -latomic")
+ list(APPEND ARROW_SHARED_INSTALL_INTERFACE_LIBS "atomic")
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS "atomic")
+endif()
+
+function(arrow_add_object_library PREFIX)
Review Comment:
I've added a docstring:
https://github.com/apache/arrow/pull/39824/commits/811674a863f949868a59a0328cc5e0fd47766d43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
