alamb commented on code in PR #9383:
URL: https://github.com/apache/arrow-datafusion/pull/9383#discussion_r1506136154
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -249,7 +249,7 @@ fn criterion_benchmark(c: &mut Criterion) {
c.bench_function("physical_plan_tpch_all", |b| {
Review Comment:
I think it would be useful to create another function that creates the
logical plan as well
```rust
c.bench_function("logical_plan_tpch_all", |b| {
b.iter(|| {
for sql in &all_tpch_sql_queries {
logical_plan(&ctx, sql)
}
})
});
```
I am happy to do this as a follow on PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
