sighingnow commented on PR #40271: URL: https://github.com/apache/arrow/pull/40271#issuecomment-1969448608
> I think this means that this should be more careful when casting. Only cast to large string if the input data is too large for a regular string array. Thanks for the suggestion, indeed that is exactly what I was considering. I have pushed an implementation which tries to cast to `StringArray` then `LargeStringArray` if failed and dispatches to a templated implementations based on the array's type in runtime. As virtual member method cannot be template, this is the simplest / least changed solution I can think of. I failed to find how to run regression benchmarks, but I have run the main branch and this PR's branch twice, the numbers looks good now.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
