ashtuchkin commented on issue #5443:
URL: https://github.com/apache/arrow-rs/issues/5443#issuecomment-1969704776

   Thanks for the context!
   
   > R.e. returning PutPart from ObjectStore, this would prevent implementation 
for LocalFilesystem and other stores that don't have native multipart.
   
   I was thinking PutPart could be returned from MultiPartStore trait, not 
ObjectStore.
   Currently although PutPart trait is public, there are no public 
implementations, which forces users to implement it for all stores themselves 
if they want to use it. It would be convenient for either MultiPartStore to 
return a private store-specific implementation, or to create a generic struct 
that would wrap a dyn MultiPartStore+location+upload_id and implement PutPart. 
The latter can be done by users of course, but arguably it would be better to 
have it in the object store library itself.
   
   If that first part is done, then just exposing PutResult on the 
WriteMultiPart struct would resolve this issue. Let me know if you'd like a PR 
for that, I can do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to