jorisvandenbossche commented on code in PR #40295:
URL: https://github.com/apache/arrow/pull/40295#discussion_r1507848831
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -2515,6 +2515,8 @@ Status ConvertChunkedArrayToPandas(const PandasOptions&
options,
std::shared_ptr<ChunkedArray> arr,
PyObject* py_ref,
PyObject** out) {
if (options.decode_dictionaries && arr->type()->id() == Type::DICTIONARY) {
+ // XXX we should return an error as below if options.zero_copy_only
+ // is true, but that would break compatibility with existing tests.
Review Comment:
At the moment we essentially just ignore the `zero_copy_only` keyword in
case of a DictionaryArray?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
