felipecrv commented on code in PR #40281:
URL: https://github.com/apache/arrow/pull/40281#discussion_r1508062334
##########
cpp/src/arrow/compute/kernels/chunked_internal.h:
##########
@@ -31,51 +31,44 @@ namespace compute {
namespace internal {
// The target chunk in a chunked array.
-template <typename ArrayType>
struct ResolvedChunk {
- using ViewType = GetViewType<typename ArrayType::TypeClass>;
- using LogicalValueType = typename ViewType::T;
-
- // The target array in chunked array.
- const ArrayType* array;
- // The index in the target array.
- const int64_t index;
-
- ResolvedChunk(const ArrayType* array, int64_t index) : array(array),
index(index) {}
-
- bool IsNull() const { return array->IsNull(index); }
-
- LogicalValueType Value() const { return
ViewType::LogicalValue(array->GetView(index)); }
-};
-
-// ResolvedChunk specialization for untyped arrays when all is needed is null
lookup
-template <>
-struct ResolvedChunk<Array> {
// The target array in chunked array.
const Array* array;
// The index in the target array.
const int64_t index;
ResolvedChunk(const Array* array, int64_t index) : array(array),
index(index) {}
+ public:
Review Comment:
I mean to make it a class and the members private. I should have done it in
this PR, but forgotten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
