milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1508164210
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1246,7 +1295,51 @@ impl QueryPlanner for DefaultQueryPlanner {
.await
}
}
+/// Crates and registers a function from [CreateFunction] statement
+///
+/// It is intended to handle `CREATE FUNCTION` statements
+/// and interact with [SessionState] to registers new udfs.
+///
+/// Datafusion `SQL` dialect does not support `CREATE FUNCTION`
+/// in generic dialect, so dialect should be changed to `PostgreSQL`
Review Comment:
looking at `FunctionRegistry.remove` method, in order to implement it
`FunctionRegistry` should be changed. Maybe that change is a bit too much for
this PR. So i propose to remove `remove` from `FunctionFactory` and add it
back when we implement `unregister_ud*` methods in `FunctionRegistry`.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
