alamb commented on code in PR #9388:
URL: https://github.com/apache/arrow-datafusion/pull/9388#discussion_r1508898077


##########
datafusion/functions/Cargo.toml:
##########
@@ -47,9 +49,22 @@ path = "src/lib.rs"
 
 [dependencies]
 arrow = { workspace = true }
+arrow-array = { workspace = true }
 base64 = { version = "0.21", optional = true }
+chrono = { workspace = true }
 datafusion-common = { workspace = true }
 datafusion-execution = { workspace = true }
 datafusion-expr = { workspace = true }
 hex = { version = "0.4", optional = true }
+itertools = { workspace = true }
 log = "0.4.20"
+rand = { workspace = true }

Review Comment:
   I think several of these dependencies are only used in the tests (so they 
could be dev depenencies). ~I'll make a follow on PR clean it up as this one is 
already really large.~
   
   Update I pushed a commit to move then to dev dependencies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to