emkornfield commented on a change in pull request #9356: URL: https://github.com/apache/arrow/pull/9356#discussion_r568962099
########## File path: csharp/src/Apache.Arrow/Arrays/DecimalArray.cs ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using Apache.Arrow.Types; + +namespace Apache.Arrow +{ + public class DecimalArray : PrimitiveArray<decimal> Review comment: The documentation is trying to say that the Decimal value is either a 128-bit or a 256-bit twos complement integer. The metadata of the type determines the scaling factor of the integer. So yes, it sounds like they are quite different. ########## File path: csharp/src/Apache.Arrow/Arrays/DecimalArray.cs ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using Apache.Arrow.Types; + +namespace Apache.Arrow +{ + public class DecimalArray : PrimitiveArray<decimal> Review comment: Yes, we ignore most significant bits of the integer (that would correspond to higher necessary precision). I'm sure some code might break if those bits are populated. But for instance we use this fact when writing to parquet: https://github.com/apache/arrow/blob/0e8de085f4afd3c9aa9c9ed05405a6c6ef8c360a/cpp/src/parquet/column_writer.cc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
