alamb commented on code in PR #9393:
URL: https://github.com/apache/arrow-datafusion/pull/9393#discussion_r1509353216
##########
datafusion/expr/src/field_util.rs:
##########
@@ -89,10 +89,11 @@ impl GetFieldAccessSchema {
Self::ListRange { start_dt, stop_dt, stride_dt } => {
match (data_type, start_dt, stop_dt, stride_dt) {
(DataType::List(_), DataType::Int64, DataType::Int64,
DataType::Int64) => Ok(Field::new("list", data_type.clone(), true)),
- (DataType::List(_), _, _, _) => plan_err!(
+ (DataType::LargeList(_), DataType::Int64, DataType::Int64,
DataType::Int64) => Ok(Field::new("large_list", data_type.clone(), true)),
Review Comment:
Look like the case for
```rust
Self::ListIndex{ key_dt } => {
```
is also missing `LargeList` case -- maybe we can add that as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
