alamb commented on issue #9415:
URL: 
https://github.com/apache/arrow-datafusion/issues/9415#issuecomment-1973719267

   The way we get spans in InfludDb is to use 
[metrics](https://docs.rs/datafusion/latest/datafusion/physical_plan/trait.ExecutionPlan.html)
 which has the start/stop times as well as counters of what rows have been 
produced, time the execution started, stopped, and various other things
   
   The DataFusion metrics --> jarger span exporter for InfluxDB 3.0 can be 
found here 
https://github.com/influxdata/influxdb/blob/8fec1d636e82720389d06355d93245a06a8d90ad/iox_query/src/exec/query_tracing.rs#L93-L112
   
   It uses our own span generation system as the rust ecosystem didn't have a 
standard library that we could find when we originally wrote it.
   
   
   One possibility might be to refactor the code out of `InfluxDB` to make it 
generic (so it didn't depend on 
[span](https://github.com/influxdata/influxdb/blob/8fec1d636e82720389d06355d93245a06a8d90ad/trace/src/span.rs),
 but instead was implemented in terms of some trait (which we could then `impl` 
for `span`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to