joellubi commented on code in PR #40284:
URL: https://github.com/apache/arrow/pull/40284#discussion_r1509533629
##########
cpp/src/arrow/flight/sql/server_session_middleware.cc:
##########
@@ -80,7 +80,7 @@ class ServerSessionMiddlewareImpl : public
ServerSessionMiddleware {
Status CloseSession() override {
const std::lock_guard<std::shared_mutex> l(mutex_);
- if (static_cast<bool>(session_)) {
+ if (!static_cast<bool>(session_)) {
Review Comment:
@indigophox As I was writing this, the following idea occurred to me:
What if, in the meantime while the C++ issue is getting resolved, we changed
the C++ implementation to respond with `CloseSessionResult_NOT_CLOSEABLE` to
all `CloseSessionRequest`'s? Admittedly that's not exactly what I imagined that
result status would end up being used for, but it's kind of accurate right now
and most importantly it gives _some_ information to clients to be able recover
the edge case gracefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
