alamb commented on code in PR #9425:
URL: https://github.com/apache/arrow-datafusion/pull/9425#discussion_r1510006973
##########
datafusion/functions-array/src/kernels.rs:
##########
@@ -319,3 +316,125 @@ pub fn gen_range(
)?);
Ok(arr)
}
+
+/// Returns the length of each array dimension
Review Comment:
I know this is just following the existing pattern of array_functions, but I
wonder if it would be better to organize the code by function.
For example, we could put the UDF and implementations in
`datafusion/functions-array/src/dims.rs` 🤔
We could definitely do this as a follow on PR
Any thoughts @jayzhan211 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
