alamb commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510009696
##########
datafusion/physical-expr/benches/regexp.rs:
##########
@@ -23,15 +23,12 @@ use std::sync::Arc;
use arrow_array::builder::StringBuilder;
use arrow_array::{ArrayRef, StringArray};
use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use datafusion_functions::regex::regexplike::regexp_like;
Review Comment:
Rather than making this dependency, I think we could instead move the
benchmark (for regexp_like) to datafusion/functions/benches/regex.rs?
##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -61,6 +61,7 @@ chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-functions = { workspace = true }
Review Comment:
I don't think we should have a dependence between datafusion-functions and
datafusion-physical-exprs as we are trying to make the crates more
indenpendent. I commented below on some ways to avoid this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
