andygrove commented on code in PR #599:
URL:
https://github.com/apache/arrow-datafusion-python/pull/599#discussion_r1510025525
##########
src/expr.rs:
##########
@@ -306,49 +307,81 @@ impl PyExpr {
/// Extracts the Expr value into a PyObject that can be shared with Python
pub fn python_value(&self, py: Python) -> PyResult<PyObject> {
match &self.expr {
- Expr::Literal(scalar_value) => Ok(match scalar_value {
Review Comment:
The main change here was to remove the `Ok` wrapping the result of the
`match` and moving into the match arms so that we can have some of them return
`Err` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
