tustvold commented on code in PR #5456:
URL: https://github.com/apache/arrow-rs/pull/5456#discussion_r1510030578
##########
arrow-array/src/array/union_array.rs:
##########
@@ -237,8 +238,9 @@ impl UnionArray {
///
/// # Panics
///
- /// Panics if `index` is greater than the length of the array.
+ /// Panics if `index` is greater than or equal to the length of the array.
Review Comment:
```suggestion
/// Panics if `index` is greater than or equal to the number of child
arrays
```
##########
arrow-array/src/array/union_array.rs:
##########
@@ -226,9 +226,10 @@ impl UnionArray {
///
/// # Panics
///
- /// Panics if the `type_id` provided is less than zero or greater than the
number of types
+ /// Panics if the `type_id` provided is less than zero or greater than or
equal the number of types
Review Comment:
```suggestion
/// Panics if the `type_id` provided is not present in the array's
DataType
```
As the type signature can skip over type ids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
