alamb commented on code in PR #9429:
URL: https://github.com/apache/arrow-datafusion/pull/9429#discussion_r1510058727
##########
datafusion/sqllogictest/test_files/timestamps.slt:
##########
@@ -465,6 +465,10 @@ SELECT TIME 'not a time' as time;
query error Cannot cast string '24:01:02' to value of Time64\(Nanosecond\) type
SELECT TIME '24:01:02' as time;
+# invalid timezone
Review Comment:
I am sorry -- I didn't see this initially.
##########
datafusion/functions/src/datetime/to_timestamp.rs:
##########
@@ -561,6 +561,31 @@ mod tests {
Ok(())
}
+ #[test]
+ fn to_timestamp_with_invalid_tz() -> Result<()> {
Review Comment:
I think the slt coverage is sufficient, so this test is not necessary.
However, I don't think that would stop this PR from merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
