jayzhan211 commented on issue #8846:
URL:
https://github.com/apache/arrow-datafusion/issues/8846#issuecomment-1975067930
I found that I need to change the signature of `create_hashes` from `arrays:
&[ArrayRef]` to `arrays: &[&dyn Array],`
```rust
pub fn create_hashes<'a>(
arrays: &[&dyn Array],
random_state: &RandomState,
hashes_buffer: &'a mut Vec<u64>,
) -> Result<&'a mut Vec<u64>> {
```
Because now, we can only get `&dyn Array` from `fn get()` for `Scalar`
Is this breaking change reasonable?
Also, `get_row_at_idx` and maybe others that has argument type
`&[ArrayRef]`, is there any function that should not be changed from
`&[ArrayRef]` to `&[&dyn Array]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
