alamb commented on PR #9304:
URL: 
https://github.com/apache/arrow-datafusion/pull/9304#issuecomment-1975068863

   > I'm not sure why we should avoid returning schema, others make sense to me
   
   I was thinking we should stay true to the design intent on `SimplifyInfo` 
that says it was designed to avoid having to create DFSchema objects. 
   
   If we were going to require DFSChema I think we could simply get rid of 
`SimplifyInfo` entirely 🤔 
   
   ```rust
   /// The information necessary to apply algebraic simplification to an
   /// [Expr]. See [SimplifyContext] for one concrete implementation.
   ///
   /// This trait exists so that other systems can plug schema
   /// information in without having to create `DFSchema` objects. If you
   /// have a [`DFSchemaRef`] you can use [`SimplifyContext`]
   pub trait SimplifyInfo {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to