devinjdangelo commented on code in PR #9431: URL: https://github.com/apache/arrow-datafusion/pull/9431#discussion_r1510401759
########## datafusion/sqllogictest/test_files/insert_to_external.slt: ########## @@ -99,9 +99,11 @@ select * from dictionary_encoded_arrow_test_readback; ---- b -# https://github.com/apache/arrow-datafusion/issues/7816 -query error DataFusion error: Arrow error: Schema error: project index 1 out of bounds, max field 1 Review Comment: Very nice! Glad to see the fix was essentially the same for arrow files. ########## datafusion/sqllogictest/test_files/ddl.slt: ########## @@ -490,20 +490,28 @@ DROP TABLE csv_with_timestamps statement ok CREATE EXTERNAL TABLE csv_with_timestamps ( - name VARCHAR, - ts TIMESTAMP, c_date DATE, + name VARCHAR, Review Comment: Definitely feel free to file an issue if you came across an unrelated problem or something confusing where we could improve documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
