SteveLauC commented on code in PR #9439:
URL: https://github.com/apache/arrow-datafusion/pull/9439#discussion_r1510450383
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -2497,155 +2497,6 @@ mod tests {
BooleanArray
);
#[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("abc"), lit("c"),],
- Ok(Some(3)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("abc"), lit("d")],
- Ok(Some(0)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("abc"), lit("")],
- Ok(Some(1)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("Helloworld"), lit("world")],
- Ok(Some(6)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("Helloworld"), lit(ScalarValue::Utf8(None))],
- Ok(None),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit(ScalarValue::Utf8(None)), lit("Hello")],
- Ok(None),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[
- lit(ScalarValue::LargeUtf8(Some("Helloworld".to_string()))),
- lit(ScalarValue::LargeUtf8(Some("world".to_string())))
- ],
- Ok(Some(6)),
- i64,
- Int64,
- Int64Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[
- lit(ScalarValue::LargeUtf8(None)),
- lit(ScalarValue::LargeUtf8(Some("world".to_string())))
- ],
- Ok(None),
- i64,
- Int64,
- Int64Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[
- lit(ScalarValue::LargeUtf8(Some("Helloworld".to_string()))),
- lit(ScalarValue::LargeUtf8(None))
- ],
- Ok(None),
- i64,
- Int64,
- Int64Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("josé"), lit("é"),],
- Ok(Some(4)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("joséésoj"), lit("so"),],
- Ok(Some(6)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("joséésoj"), lit("abc"),],
- Ok(Some(0)),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit(ScalarValue::Utf8(None)), lit("abc"),],
- Ok(None),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(feature = "unicode_expressions")]
- test_function!(
- Strpos,
- &[lit("joséésoj"), lit(ScalarValue::Utf8(None)),],
- Ok(None),
- i32,
- Int32,
- Int32Array
- );
- #[cfg(not(feature = "unicode_expressions"))]
- test_function!(
- Strpos,
- &[
- lit("joséésoj"),
- lit(ScalarValue::Utf8(None)),
- ],
- internal_err!(
- "function strpos requires compilation with feature flag:
unicode_expressions."
- ),
- i32,
- Int32,
- Int32Array
- );
Review Comment:
This is also not ported because I think we cannot do this with Sqllogictest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
