Dandandan commented on code in PR #9442:
URL: https://github.com/apache/arrow-datafusion/pull/9442#discussion_r1510597248
##########
datafusion/sqllogictest/src/engines/postgres_engine/types.rs:
##########
@@ -37,8 +38,8 @@ impl<'a> FromSql<'a> for PgRegtype {
}
}
-impl ToString for PgRegtype {
- fn to_string(&self) -> String {
- self.value.clone()
+impl Display for PgRegtype {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "{}", self.value.clone())
Review Comment:
No clone needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
