judahrand commented on code in PR #39506:
URL: https://github.com/apache/arrow/pull/39506#discussion_r1510997760
##########
python/pyarrow/table.pxi:
##########
@@ -2688,6 +3002,69 @@ cdef class RecordBatch(_Tabular):
return result
+ def cast(self, Schema target_schema, safe=None, options=None):
Review Comment:
I wasn't sure which implementation of `cast` to keep. Pros and cons to both.
The code duplication isn't great but it is the pattern that the rest of the
similar implementations use and it means we don't create an extra `Table` 🤷♂️
https://github.com/apache/arrow/pull/39506/commits/389e547a07c44ea2e755de84d2e0fe19c5c677cd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
