ritchie46 commented on pull request #9404: URL: https://github.com/apache/arrow/pull/9404#issuecomment-772707038
> Note that there may be out-of-bound reads on that code. It would be awesome if those were taken care of :) Ah, right so we want to `panic` if we have out-of-bounds access even if `check-bounds == false`. There are quite some cases where I know upfront that all my indexes will be valid. Should we also expose an unsafe variant of the take kernels? Especially in groupby and join operations their performance is paramount. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
