viirya commented on code in PR #155:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/155#discussion_r1511509125
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -38,6 +38,25 @@ import
org.apache.comet.CometSparkSessionExtensions.isSpark34Plus
* Test suite dedicated to Comet native aggregate operator
*/
class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
+ import testImplicits._
+
+ test("Final aggregation should not bind to the input of partial
aggregation") {
Review Comment:
Btw, we need to add the bound check as required for SortMergeJoin work. In
that work, it checks joining keys bindings internally in DataFusion. Which
checks both binding index and binding column name. So we need to bind column
reference to input schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
