joellubi commented on PR #1590: URL: https://github.com/apache/arrow-adbc/pull/1590#issuecomment-1977339591
> See #1572 @lidavidm I'm just seeing this. Looks like we did some things similarly in our implementations and could likely combine them. One question I had while going through this: Right now the `(Driver|Database|Connection|Statement)ImplBase` types _partially_ implement the corresponding interfaces. Most methods are explicitly required to be implemented by the driver developer to satisfy the interface at all. Should the bases instead fully implement the interface (with methods that return `NotImplemented` errors) as a starting point like the current FlightSQL BaseServer does? There are benefits I can think of to either approach. Implementing the interface fully makes it easier to get started with a driver that at least compiles with the functionality the author cares about. This has a slight downside that it might make it a bit harder to see what's missing from an implementation to make it complete, at least in terms of static analysis. What are your thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
