MohamedAbdeen21 opened a new pull request, #9452:
URL: https://github.com/apache/arrow-datafusion/pull/9452

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #9294.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   Documentation states that datafusion-cli can be installed through pip; 
however, that is not the case. This adds a workflow to deploy datafusion-cli 
(and only the CLI, not the python module) to PyPI to be installed through pip.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   This is meant to be a draft CI, to be reviewed and edited as necessary by 
maintainers. 
   
   CC @andygrove as I see he's involved in arrow-datafusion-python workflows.
   
   A final note: builds for 32-bit systems fail because of  `src/main.rs:304` 
which expects `1 << 40` to be usize, which is not always the case, therefore 
causing rust to panic because of overflow.
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   -->
   
   You can try testing the deployment yourself using `pip install 
datafusion-cli`. I thought I changed the name and the repo target to my fork, 
but apparently not.
   
   I'll remove it from PyPI once the PR is ready to merge, to be reopened by 
the maintainers.
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   Should be able to use pip to install datafusion-cli
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to