viirya commented on code in PR #169:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/169#discussion_r1513251233
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1790,43 +1790,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
case _ => return None
}
- val output = mode match {
- case CometAggregateMode.Partial => child.output
- case CometAggregateMode.Final =>
- // Assuming `Final` always follows `Partial` aggregation, this
find the first
- // `Partial` aggregation and get the input attributes from it.
- // During finding partial aggregation, we must ensure all
traversed op are
- // native operators. If not, we should fallback to Spark.
- var seenNonNativeOp = false
- var partialAggInput: Option[Seq[Attribute]] = None
Review Comment:
Oh, right, this is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
