alamb commented on code in PR #9454:
URL: https://github.com/apache/arrow-datafusion/pull/9454#discussion_r1513529783
##########
datafusion/functions/Cargo.toml:
##########
@@ -55,10 +55,11 @@ chrono = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-physical-expr = { workspace = true, default-features = true }
hex = { version = "0.4", optional = true }
itertools = { workspace = true }
log = { workspace = true }
-
+regex = { version = "1.8" }
Review Comment:
Since this is only needed for the regular expressions, I think we can mark
it optional like
```suggestion
regex = { version = "1.8", optional = true }
```
And then change this above from
```toml
regex_expressions = []
```
to
```toml
regex_expressions = ["regex"]
```
I'll do this in a follow on PR
##########
datafusion/physical-expr/src/lib.rs:
##########
@@ -32,8 +32,6 @@ pub mod math_expressions;
mod partitioning;
mod physical_expr;
pub mod planner;
-#[cfg(feature = "regex_expressions")]
Review Comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
