viirya commented on code in PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459#discussion_r1513598236
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -408,8 +412,19 @@ fn coerced_from<'a>(
Some(type_into.clone())
}
- // cannot coerce
- _ => None,
+ // More coerce rules.
+ // Note that not all rules in `comparison_coercion` can be reused here.
+ // For example, all numeric types can be coerced into Utf8 for
comparison,
+ // but not for function arguments.
+ _ => comparison_binary_numeric_coercion(type_into, type_from).and_then(
+ |coerced_type| {
+ if *type_into == coerced_type {
+ Some(coerced_type)
+ } else {
Review Comment:
For function argument, we want to coerce to exact the type (valid type)
instead of third type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
