ClifHouck commented on code in PR #40067:
URL: https://github.com/apache/arrow/pull/40067#discussion_r1514919160
##########
cpp/src/arrow/compute/kernels/scalar_cast_numeric.cc:
##########
@@ -151,6 +174,10 @@ Status CheckFloatToIntTruncation(const ExecValue& input,
const ExecResult& outpu
return CheckFloatToIntTruncationImpl<FloatType>(input.array,
*output.array_span());
case Type::DOUBLE:
return CheckFloatToIntTruncationImpl<DoubleType>(input.array,
*output.array_span());
+ // FIXME: Is this OK? It seems like the underlying check may not operator
correctly
Review Comment:
Need to remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
