viirya commented on code in PR #166: URL: https://github.com/apache/arrow-datafusion-comet/pull/166#discussion_r1514942197
########## .github/actions/setup-spark-builder/action.yaml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Setup Spark Builder +description: 'Setup Apache Spark to run SQL tests' +inputs: + spark-short-version: + description: 'The Apache Spark short version (e.g., 3.4) to build' + required: true + default: '3.4' + spark-version: + description: 'The Apache Spark version (e.g., 3.4.2) to build' + required: true + default: '3.4.2' + comet-version: + description: 'The Comet version to use for Spark' + required: true + default: '0.1.0-SNAPSHOT' +runs: + using: "composite" + steps: + - name: Clone Spark repo + uses: actions/checkout@v4 + with: + repository: apache/spark + path: apache-spark + ref: v${{inputs.spark-version}} + fetch-depth: 1 + + - name: Setup Spark for Comet + shell: bash + run: | + cd apache-spark + git apply ../dev/diffs/${{inputs.spark-version}}.diff Review Comment: For the diff, one issue is it is hard to maintain and review. Especially for the first one shot like this. But it should be less severe as latter change to this diff should be rare and small, except for a new Spark version (like 3.5). > Yes, I think it'd be useful to have a forked repo tracking the Comet changes to Spark. Maybe we can just use branches in this repo? We could run tests to validate the changes too through Github CI. You mean to have a branch in Comet repo which has forked Spark code with this diff? I think it is better than a personal repo so more people can maintain the branch. For now, I think we can have the diff first and apply it during CI test as we did currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
